Another round removing warnings #24500
Merged
+26
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
commented
Nov 21, 2025
| /** stringOf formatted for use in a repl result. */ | ||
| def replStringOf(arg: Any, maxElements: Int): String = | ||
| stringOf(arg, maxElements) match { | ||
| case null => "null toString" |
Member
Author
There was a problem hiding this comment.
stringOf(null, maxElements) = "null", this is indeed not reachable.
Contributor
There was a problem hiding this comment.
That was for a non-null value for which toString returns null.
Member
Author
There was a problem hiding this comment.
I see, in this case, stringOf should return String | Null. I will remove that commit from this PR until we check what we will do in this case.
hamzaremmal
commented
Nov 21, 2025
| def next(): R = | ||
| if(!hasNext) Iterator.empty.next() | ||
| else node match { | ||
| else node.nn match { |
Member
Author
There was a problem hiding this comment.
the call to hasNext before makes sure that indeed node is not null. This was an exhaustivity warning (missing case null).
hamzaremmal
commented
Nov 21, 2025
hamzaremmal
force-pushed
the
less-warnings
branch
from
c45ea37 to
55db92a
Compare
WojciechMazur
approved these changes
Nov 21, 2025
hamzaremmal
added a commit
that referenced
this pull request
Nov 21, 2025
#24500 was on auto-merge and it failed because the positions were changed. This PR fixes the positions while I also updated the branch requirements for a PR to include all the jobs (excluding some of the non-bootstrapped for now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we still have pattern matching warnings, init warnings, a bug in the deprecatedOverride logic that triggers warnings because of generated code and some CC warnings too.